Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ML/LangChain: Fix notebooks and tests #710

Merged
merged 2 commits into from
Nov 3, 2024
Merged

ML/LangChain: Fix notebooks and tests #710

merged 2 commits into from
Nov 3, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Nov 3, 2024 •
edited
Loading

About

  • 9801b61 fixes a programming error that prevented signaling execution failures on the notebooks the job verifies.
  • 2f5d4f9 fixes relevant shortcomings of the notebooks-under-test that have been revealed right away.

/cc @kneth

@cla-bot cla-bot bot added the cla-signed label Nov 3, 2024
@amotl amotl force-pushed the fix-notebook-tests branch from dee740e to 0fa4c55 Compare November 3, 2024 15:00
@amotl amotl changed the title ML/LangChain: Fix notebook tests ML/LangChain: Fix notebooks and tests Nov 3, 2024
@amotl amotl force-pushed the fix-notebook-tests branch from 0fa4c55 to 2f5d4f9 Compare November 3, 2024 16:51
@amotl amotl marked this pull request as ready for review November 3, 2024 17:00
@amotl amotl merged commit a4e9c1c into main Nov 3, 2024
4 checks passed
@amotl amotl deleted the fix-notebook-tests branch November 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonprickett simonprickett Awaiting requested review from simonprickett

@hammerhead hammerhead Awaiting requested review from hammerhead

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amotl