Java JDBC: Use explicit schema name testdrive
#748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, resources would be created within the `crate` schema, which might be unfortunate when users are copying the examples. The intention of the micro examples is to show users best practices.
amotl
force-pushed
the
java-jdbc-use-explicit-schema
branch
from
0bfb960 to
c907cba
Compare
kneth
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, resources would be created within the
crateschema, which might be unfortunate for various reasons.The intention of the micro examples is to show users best practices. While the documentation will certainly educate about the
docschema, I think it will be fine to use a canonical dedicated schema name for this collection of example programs?