Npgsql: Fix test cases to use async, stop relevant warnings #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
npgsql-maintenance-2014-12
branch
from
e6267f4 to
422f050
Compare
amotl
force-pushed
the
npgsql-maintenance-2014-12
branch
3 times, most recently
from
4241851 to
fd4d46f
Compare
amotl
force-pushed
the
npgsql-maintenance-2014-12
branch
from
bd58391 to
b9b9a8d
Compare
CI was accompanied by relevant warnings for a long time already. The changes about async are not related to the runner change here. The runner downgrade b62907a has been conducted in order to keep supporting .NET 7 on CI, FWIW. It doesn't hurt right now, but I guess we may phase it out while we go, as soon as it creates problems? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The test suite started emitting such warnings the other day:
-- https://github.com/crate/cratedb-examples/actions/runs/12248712216
Solution
The patch has been created by making the flagged methods and their ingredients async, following corresponding advises by the .NET runtime, and then following relevant suggestions from the PyCharm IDE.