-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Javascript: Implement ExceptionCollectorListener
and make it default behaviour.
#38
Conversation
…enrich `Statements`
40d75ab
to
d09333f
Compare
The PR might be to big to manually inspect/test, fyi it's 'already tested' (Since it's almost identical to the Python target and the test pass) I'm interested on your opinion @alexdametto of the resulting API, you can quickly check it in https://github.com/crate/cratedb-sqlparse/pull/38/files#diff-111a35f00d7bdf2e15b6a32750f253243ae44df87bcf0465a2fbfd7178db2dc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a stack! I've just added a few nit suggestions about punctuation, wording, and formatting, to accept at your disposal.
2457c17
to
d148041
Compare
With the latest commit types generation is added, it works fine on my end.
There are still some types, that are not being picked up, I do not know why, for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm interested on your opinion @alexdametto of the resulting API, you can quickly check it in https://github.com/crate/cratedb-sqlparse/pull/38/files#diff-111a35f00d7bdf2e15b6a32750f253243ae44df87bcf0465a2fbfd7178db2dc1
Amazing job. 💯 I really like it, especially the raise_exception
and the exception details, these things are definitely needed in https://github.com/crate/cloud/issues/1888.
Could be possible to add also the line number of where the error occurs? I have seen that we have it inside stmt.exception.errorMessage
but it would be good to have it stored in a separate field.
There is |
Sorry for the late review, looks good! thx a lot for the effort @surister ! |
Summary of the changes / Why this is an improvement
Implements #30 #36 #37 #34 to the Javascript target
Solves #2
Checklist
Also adds support for typescript types, solving #52.