Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Migrate from crate[sqlalchemy] to sqlalchemy-cratedb #151

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Jun 10, 2024

About

The CrateDB SQLAlchemy dialect needs more love, so it was separated from the DBAPI HTTP driver. This patch verifies and concludes the migration.

References

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.39%. Comparing base (3f7d296) to head (9b0598a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   93.39%   93.39%           
=======================================
  Files          14       14           
  Lines         227      227           
=======================================
  Hits          212      212           
  Misses         15       15           
Flag Coverage Δ
unittests 93.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The CrateDB SQLAlchemy dialect needs more love, so it was separated from
the DBAPI HTTP driver.
@amotl amotl force-pushed the sqlalchemy-cratedb branch from 7ae76fc to 9b0598a Compare June 11, 2024 02:55
@amotl amotl marked this pull request as ready for review June 11, 2024 03:44
@amotl amotl merged commit b204f46 into main Jun 11, 2024
4 checks passed
@amotl amotl deleted the sqlalchemy-cratedb branch June 11, 2024 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant