Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SQLAlchemy patches and polyfills from cratedb-toolkit #36

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Use SQLAlchemy patches and polyfills from cratedb-toolkit #36

merged 1 commit into from
Oct 10, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Oct 10, 2023

About

A few patches to make this work have been converged into the crate package, a few others went into cratedb-toolkit.

References

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
mlflow_cratedb/boot.py 100.00% <100.00%> (ø)
mlflow_cratedb/patch/mlflow/db_utils.py 71.42% <ø> (-11.91%) ⬇️
mlflow_cratedb/patch/mlflow/model.py 100.00% <100.00%> (ø)
mlflow_cratedb/patch/sqlalchemy.py 100.00% <100.00%> (+8.33%) ⬆️

📢 Thoughts on this report? Let us know!.

@amotl amotl marked this pull request as ready for review October 10, 2023 21:44
@amotl amotl merged commit b407ad7 into main Oct 10, 2023
3 checks passed
@amotl amotl deleted the use-cratedb-toolkit branch October 10, 2023 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amotl