Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: image name for oci not being passed on building gh flows #16

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: image name for oci not being passed on building gh flows #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ec406f
fix: image name on gh builder flow for crc-builder
adrianriobo Aug 1, 2024
e75f257
fix: remove duplicate steps on pusher flows
adrianriobo Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/crc-builder-builder.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
run: |
make crc-builder-oci-build
make crc-builder-oci-save
echo "image=${SNC_RUNNER}:${SNC_RUNNER_V}" >> "$GITHUB_ENV"
echo "image=${CRC_BUILDER}:${CRC_BUILDER_V}" >> "$GITHUB_ENV"

- name: Build image for Release
if: ${{ github.event_name == 'push' }}
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/crc-builder-pusher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,6 @@ jobs:
echo "source_event=$(cat crc-builder-build-event)" >> "$GITHUB_ENV"
echo "image=$(cat crc-builder-image)" >> "$GITHUB_ENV"

- name: Log in to ghcr.io for PR
if: ${{ env.source_event == 'pull_request' }}
uses: redhat-actions/podman-login@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Log in to ghcr.io
if: ${{ env.source_event == 'pull_request' }}
uses: redhat-actions/podman-login@v1
Expand All @@ -53,7 +45,7 @@ jobs:
- name: Push crc-builder
run: |
podman load -i crc-builder-linux.tar
podman manifest push ${{ env.image }}-linux
podman push ${{ env.image }}-linux
podman load -i crc-builder-windows.tar
podman push ${{ env.image }}-windows
podman load -i crc-builder-darwin.tar
Expand Down
10 changes: 1 addition & 9 deletions .github/workflows/snc-runner-pusher.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,7 @@ jobs:
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Log in to ghcr.io
if: ${{ env.source_event == 'push' }}
uses: redhat-actions/podman-login@v1
with:
registry: ghcr.io
username: ${{ github.actor }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Loginquay.io
- name: Log in to quay.io
if: ${{ env.source_event == 'push' }}
uses: redhat-actions/podman-login@v1
with:
Expand Down