Check parameters from cmd before passing to the provider #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… no `aws-disk-size` parameter was set. This behaviour was hit due to the fact that all parameters were passed to the provider, no matter if they were set or not on the cmd (with empty string as param value). This commit will check if each parameter is set on the cmd before adding it to the set of params to be passed to the aws provider.
adrianriobo
changed the title
… changed from no timeout to 15s this affects how we remote setup the cluster as it failed due the combination of timeout + # of attempts. This commit set back to no timeout on dial to ensure we keep the old behave. Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
… previous does not exist anymore. This change was originally handle on crc-org#161 Signed-off-by: Adrian Riobo Lorenzo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #164