Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use all configured ipv4 dns services #4496

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

kaovilai
Copy link
Contributor

@kaovilai kaovilai commented Dec 2, 2024

Signed-off-by: Tiger Kaovilai [email protected]

Description

Fixes: #4454
via upgrade to github.com/containers/gvisor-tap-vsock v0.8.1
Relates to: containers/gvisor-tap-vsock#426

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

Testing

Contribution Checklist

  • I have read the contributing guidelines
  • My code follows the style guidelines of this project
  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I tested my code on specified platforms
    • Linux
    • Windows
    • MacOS

@openshift-ci openshift-ci bot requested review from evidolob and gbraad December 2, 2024 21:37
Copy link

openshift-ci bot commented Dec 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anjannath for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Dec 2, 2024

Hi @kaovilai. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai kaovilai changed the title github.com/containers/gvisor-tap-vsock v0.8.1 Use all configured ipv4 dns services Dec 2, 2024
@kaovilai
Copy link
Contributor Author

kaovilai commented Dec 2, 2024

/cc @evidolob

@cfergeau
Copy link
Contributor

cfergeau commented Dec 3, 2024

You need to run go mod vendor after go get .... I expect dependabot will open a PR doing this update soon.

@cfergeau
Copy link
Contributor

cfergeau commented Dec 3, 2024

/ok-to-test

@kaovilai
Copy link
Contributor Author

kaovilai commented Dec 4, 2024

/retest

Copy link

openshift-ci bot commented Dec 4, 2024

@kaovilai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc e6135e2 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit 641d64e into crc-org:main Dec 4, 2024
21 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] 2.43.0 broke darwin public DNS query when host do not exclusively use IPv4 DNS servers.
3 participants