Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci : fix failing Test OKD Bundle GitHub action (#4556) #4557

Merged

Conversation

rohanKanojia
Copy link
Contributor

Description

Fixes: #4556

It seems OKD Bundle GitHub action is failing to locate package named virtiofsd . GitHub is rolling out Ubuntu 24.04 on it's runners,

  • if runner os is selected as 22.04 (where virtiofsd package required by CRC is already installed),
  • if it's 24.04 (where virtiofsd package is not installed)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Proposed changes

Install virtiofsd package on ubuntu runner, otherwise ignore.

Testing

After making abovementioned changes, I was able to make CI green in eclipse-jkube/jkube-integration-tests#395

Contribution Checklist

  • I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

It seems OKD Bundle GitHub action is failing to locate package named virtiofsd .
GitHub is rolling out Ubuntu 24.04 on it's runners,
- if runner os is selected  as 22.04 (where `virtiofsd` package required by CRC is already installed),
- if it's 24.04 (where `virtiofsd` package is not installed)

Signed-off-by: Rohan Kumar <[email protected]>
Copy link

openshift-ci bot commented Jan 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented Jan 8, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign cfergeau for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rohanKanojia rohanKanojia marked this pull request as ready for review January 8, 2025 12:27
@openshift-ci openshift-ci bot requested review from gbraad and praveenkumar January 8, 2025 12:27
Copy link

openshift-ci bot commented Jan 8, 2025

@rohanKanojia: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc 65ce858 link true /test integration-crc
ci/prow/e2e-crc 65ce858 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit e0f93c5 into crc-org:main Jan 9, 2025
29 of 36 checks passed
@rohanKanojia rohanKanojia deleted the pr/fix-ci-okd-workflow branch January 9, 2025 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] Test OKD Bundle GitHub Action workflow failing
2 participants