Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: disable post-start functions that are done in snc #4560

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anjannath
Copy link
Member

Description

This removes code doing the various post-start cluster provisioning tasks which are moved to the self sufficient bundle as part of PR crc-org/snc#980

Relates to: crc-org/snc#638

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Testing

  1. crc start should be successful when using the bundle from [wip] add systemd services for configuration after start snc#980 (linux and windows bundle can be downloaded from the opensift CI artifacts https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/crc-org_snc/980/pull-ci-crc-org-snc-master-e2e-snc/1876969244206305280/)
  2. crc start should also succeed when using the current released bundle (4.17.0 or 4.17.10)

Contribution Checklist

  • Which platform have you tested the code changes on?
    • Linux
    • Windows
    • MacOS

Copy link

openshift-ci bot commented Jan 9, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from anjannath. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from cfergeau and evidolob January 9, 2025 09:27
Copy link

openshift-ci bot commented Jan 9, 2025

@anjannath: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 5b0562f link false /test security
ci/prow/e2e-microshift-crc 5b0562f link true /test e2e-microshift-crc
ci/prow/e2e-crc 5b0562f link true /test e2e-crc
ci/prow/images 5b0562f link true /test images
ci/prow/integration-crc 5b0562f link true /test integration-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant