Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc : modify troubleshooting scenario to use description lists #10

Conversation

rohanKanojia
Copy link
Contributor

Description

Follow up PR to #8 to address review comment from @themr0c

Find log file in `~/.crc/vfkit.log`
https://learn.microsoft.com/en-us/virtualization/hyper-v-on-windows/about/[hyper-v]::
Event Logs for Hyper-V:::
.. Go to start and open `Event Viewer`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick

Suggested change
.. Go to start and open `Event Viewer`
.. Go to start and open `Event Viewer`.

https://libvirt.org/kbase/debuglogs.html[libvirt]::
Find the log file in `/var/log/libvirt/qemu/crc.log`
https://github.com/crc-org/vfkit[vfkit]::
Find log file in `~/.crc/vfkit.log`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another nitpick for consistency with previous sentence:

Suggested change
Find log file in `~/.crc/vfkit.log`
Find the log file in `~/.crc/vfkit.log`

Copy link
Contributor

@gbraad gbraad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned by Fabrice.
Avoid stylizing text to draw attention.

Follow up PR to crc-org#8 to address review
comment from @themr0c

Signed-off-by: Rohan Kumar <[email protected]>
@rohanKanojia rohanKanojia force-pushed the pr/troubleshooting-improvements-followup branch from 898cbba to ef4a321 Compare December 2, 2024 12:38
@rohanKanojia rohanKanojia requested a review from themr0c December 2, 2024 12:49
@gbraad gbraad merged commit fda573a into crc-org:main Dec 4, 2024
1 check passed
@rohanKanojia rohanKanojia deleted the pr/troubleshooting-improvements-followup branch December 4, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants