Skip to content

Commit

Permalink
Don't wait for VM to stop in case of delete
Browse files Browse the repository at this point in the history
`Remove ()` function should not call `Stop ()`
and wait till stop return since stop do graceful
shutdown of the VM which we don't need in case of
remove, otherwise `delete` operation will be waiting
more than 1-2 mins which is not acceptable.
  • Loading branch information
praveenkumar committed Jul 19, 2019
1 parent d89dd2c commit 90a69ed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/hyperkit/driver.go
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ func (d *Driver) Remove() error {
log.Debugf("Error checking machine status: %v, assuming it has been removed already", err)
}
if s == state.Running {
if err := d.Stop(); err != nil {
if err := d.Kill(); err != nil {
return err
}
}
Expand Down

0 comments on commit 90a69ed

Please sign in to comment.