-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run OpenShift reliability/minimal test suite #456
base: master
Are you sure you want to change the base?
Conversation
/retest |
3 similar comments
/retest |
/retest |
/retest |
Compared to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bunch of questions, but overall looks good!
ci.sh
Outdated
@@ -47,7 +47,7 @@ sudo mv out/linux-amd64/crc /usr/local/bin/ | |||
popd | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expand the commit log a bit, Giving more resources to the cluster we run the testsuite on should hopefully prevent some disruptions/timeouts/... because of low memory conditions
snc.sh
Outdated
# Remove the openshift-authenticator CSR to force a certificate regeneration | ||
# BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1978193 | ||
retry ${OC} delete csr system:openshift:openshift-authenticator | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we made a 4.8 release without this, I'm not sure what is the impact of this? Surely this deserves to be in a PR of its own?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cfergeau I am considering 2 things when going with this suite.
About naming I need to confirm with openshift team but as per description it says About removed 103 tests from |
/test e2e-snc |
1 similar comment
/test e2e-snc |
It's relatively recent, maybe that explains the
Disappointing that we still need to disable ~20 tests from this list :(
Most of these are readded when moving from
But only the complete conformance test suite gives us some "this behaves as an OpenShift cluster" label, so we'll have to take these 2-3h at some point. Running a subset of these tests is better than nothing, but is not our end goal :) |
|
Yes this is the end goal, I am hoping we can piggy back on SNO team in near future to try to run complete suite because if they need a bump on CI time then we can directly benefited from it. |
@cfergeau I run tests on this PR 3 times and no single failure https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/pull-ci-code-ready-snc-master-e2e-snc so I am bit confident to have it. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could go with this for now.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
New changes are detected. LGTM label has been removed. |
/retest |
Rather than kubernetes/conformance, this attempts to run openshift reliability/minimal tests. This also adds some tests to ignore list which was failing during testing due to apiserver unavailblity or single node constrain. Plan is to reduce this ignore list and also try to add openshift conformance test in future. ``` experimental/reliability/minimal Set of highly reliable tests. ```
/retest |
/retest |
2 similar comments
/retest |
/retest |
/hold |
@praveenkumar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Rather than kubernetes/conformance, this attempts to run
openshift reliability/minimal tests. This also adds some tests to
ignore list which was failing during testing due to apiserver
unavailblity or single node constrain. Plan is to reduce this ignore
list and also try to add openshift conformance test in future.
This is not supersede #399 but a different subset of tests which is part of openshift instead plain k8s.