Add vf.VirtualMachine and vf.VirtualMachineConfiguration types #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's only used in the vf package, so it can be renamed to toVzBootloader Signed-off-by: Christophe Fergeau <[email protected]>
All other methods are named toVz() with a lower-case 'z' Signed-off-by: Christophe Fergeau <[email protected]>
The rest/vf package introduces a `VzVirtualMachine` type to wrap virtual machine interactions. This type is a struct with a `VzVM *vz.VirtualMachine` member. This commit makes this struct member anonymous instead of naming it `VzVM`, this allows to remove the VzVirtualMachine state related methods which were thin wrappers over methods with (almost) the same name already defined in `*vz.VirtualMachine`. Signed-off-by: Christophe Fergeau <[email protected]>
This commit renames vzVirtualMachineConfiguration to VirtualMachineConfig. vzVirtualMachineConfiguration was a wrapper over the Code-Hex/vz type vz.VirtualMachineConfiguration. VirtualMachineConfig improves vzVirtualMachineConfiguration because it also keeps around the config.VirtualMachine go object which was used to created the vz.VirtualMachineConfiguration object. This will be useful in simplifying the code using the pkg/vf package. Signed-off-by: Christophe Fergeau <[email protected]>
Similarly to the vf.VirtualMachineConfiguration type introduced in the previous commit, the vf.VirtualMachine type wraps both a vz.VirtualMachine instance, and the vfkit/go data which was used to generate it, which is the aforementioned VirtualMachineConfiguration type. This allows to simplify some users of pkg/vf, in particular the rest code. `code-hex/vz` is now only imported in pkg/vf Signed-off-by: Christophe Fergeau <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new types, which hopefully will help to make the code clearer.
Some of the benefits are that Code-Hex/vz is now only imported in pkg/vf instead of being used directly in multiple places.
The REST code is also simplified.
This is preparation work for #48: the changes in the current PR will be useful for adding the path to the pty device in the REST API.
There should be no user-visible changes after this PR, just internal improvements.