Add consistent naming of writers #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, move Java2dBufferedImageWriter to separate file
noelwelsh
approved these changes
Mar 17, 2024
| import doodle.algebra.Algebra | ||
| import doodle.algebra.Picture | ||
| import doodle.core.format.Format | ||
|
|
There was a problem hiding this comment.
Suggested change
| /** Marker trait for effects that write a picture to a file or some other type. */ |
Adding basic ScalaDoc, especially for the parts of the code that are user level concepts, is a good practice.
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I renamed all "writing" effects to have a suffix
Writer, updated sytax and movedJava2dBuffereImageWriterto a separate file. Additionally, I moved therenderBufferedImage()method fromJava2dWriterto aJava2das it is now used by multiple files. I decided not to proceed with creating a separate file to store all of the actuall writer objects as with therenderBufferedImage()method moved it seems to make more sense to leave them as they are (otherwise this file would become very large very quickly).Closes #146