Fixed the image bug on Laika site and added a few alts #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noelwelsh
requested changes
Apr 13, 2024
docs/src/pages/pictures/shape.md
Outdated
| @@ -20,7 +20,10 @@ val basicShapes = | |||
|
|
|||
| This program gives the output below. | |||
|
|
|||
| @:image(basic-shapes.png) | |||
| @:image(basic-shapes.png) { | |||
| alt = A circle, square, and triangle | |||
There was a problem hiding this comment.
I think you need to quote this string and the one below it, as the commas seem to throw off the parser.
There was a problem hiding this comment.
Done, removed the commas
docs/src/pages/pictures/red-blue.png
Outdated
There was a problem hiding this comment.
The code producing this file should be in docs/src/main/scala/pictures/Layout.scala. The convention the docs are moving to is to not include the pictures but generate them from code every time the documentation is built.
There was a problem hiding this comment.
I've created another object ImageObj considering it being on different page from layout. Let me know if it's required to shift to layout.scala
|
Thanks! I'll fix the remaining little issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed red-blue image bug, which was missing in /pictures. Also added alts and titles to other images.