Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #36

Merged
merged 6 commits into from
Jul 11, 2022
Merged

Update all dependencies #36

merged 6 commits into from
Jul 11, 2022

Conversation

mibmo
Copy link
Contributor

@mibmo mibmo commented Jun 11, 2022

Bumps dependencies.

Dependency Old tag New tag
OpenSSL OpenSSL_1_0_2p OpenSSL_1_1_1o
Libevent release-2.1.8-stable release-2.1.12-stable
zlib v1.2.11 v1.2.12
XZ Utils v5.2.4 v5.2.5
Tor tor-0.3.5.7 tor-0.4.7.7

Tests aren't working yet, as this requires updating Bine as well.

Unblocks #35
Somewhat closes #16

@mibmo mibmo mentioned this pull request Jun 11, 2022
7 tasks
@cretz
Copy link
Owner

cretz commented Jun 13, 2022

Can you confirm this version of Tor works w/ your Bine PR?

Also, I wonder if it might be worth/necessary to update any dependencies? Especially OpenSSL if at all possible.

@mibmo
Copy link
Contributor Author

mibmo commented Jun 17, 2022

Can you confirm this version of Tor works w/ your Bine PR?

Yep 👍

Also, I wonder if it might be worth/necessary to update any dependencies? Especially OpenSSL if at all possible.

That's probably a good idea; I'll bump all the dependencies. Perhaps it'd be possible to get dependabot running? not sure if it can handle submodules though.

@mibmo mibmo changed the title Update tor version to 0.4.7.7 Update all dependencies Jun 17, 2022
@cretz
Copy link
Owner

cretz commented Jun 17, 2022

Looks good! Feel free to merge if it builds well with all new dependencies. Can see about getting dependabot running a bit later, but yeah unsure about submodules.

(ignore the failed appveyor build)

@mibmo
Copy link
Contributor Author

mibmo commented Jul 1, 2022

I haven't tested it thoroughly yet (it builds), so I'll wait on OK-ing the merge, but I hope to get it done soon-ish :)

@mibmo
Copy link
Contributor Author

mibmo commented Jul 10, 2022

Alright, I've tested again & seems to be the exact same (tested with CI as well).

Wouldn't mind if you tested it as well, but that's not strictly necessary. :)
I think you're good to go in terms of merging.

@cretz cretz merged commit 0ba4ca6 into cretz:master Jul 11, 2022
@cretz
Copy link
Owner

cretz commented Jul 11, 2022

Merged

@mibmo mibmo deleted the update-tor branch April 10, 2023 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make 0.4.x release
2 participants