Int ghost methods
#1281
Merged
Int ghost methods
#1281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Right now this bumps into limitations of the purity check, so #[pure]
fn add(x: Int, y: Int) -> Int {
x + y
}is rejected because the trait function |
Huh, you mean that we don't resolve trait methods in the purity check? We should! |
|
Hum nevermind, I just forgot a |
jhjourdan
reviewed
Dec 3, 2024
arnaudgolfouse
force-pushed
the
int-ghost-methods
branch
3 times, most recently
from
05351d4 to
d285d5a
Compare
jhjourdan
reviewed
Dec 3, 2024
| "mul" | "add" | "sub" | "div" | "rem" | "neg" | "box_new" | "deref_method" | ||
| | "deref_mut_method" => true, | ||
| "box_new" | "deref_method" | "deref_mut_method" => true, |
jhjourdan
reviewed
Dec 3, 2024
arnaudgolfouse
force-pushed
the
int-ghost-methods
branch
from
d285d5a to
363d866
Compare
|
Overall, LGTM. @laurentder : this should fix your issues about machine arithmetics in pearlite specifications, since they are all rewritten. |
arnaudgolfouse
force-pushed
the
int-ghost-methods
branch
from
084a3da to
d944e6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow using operators (
+,*...) onIntin ghost code.This works because it is never possible to get an
Intin normal (non-ghost) code.Fixes #1271.