Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for iterators of HashMap and HashSet #1306

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Conversation

Lysxia
Copy link
Collaborator

@Lysxia Lysxia commented Dec 13, 2024

with some tests that into_iter followed by collect is the identity.

Other methods to be specified in another upcoming PR.

Copy link
Collaborator

@jhjourdan jhjourdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somewhat weird, because we don't sepcify anything about hash maps apart from iterators!

creusot-contracts/src/std/collections/hash_map.rs Outdated Show resolved Hide resolved
@Lysxia Lysxia force-pushed the contracts-hashmaps branch from 90dfbca to a0e1d4f Compare December 13, 2024 14:40
@Lysxia
Copy link
Collaborator Author

Lysxia commented Dec 13, 2024

The reason why specs for iterators come first is that they are necessary for creusot to compile for loops, whereas other missing specs only cause warnings.

@Lysxia Lysxia force-pushed the contracts-hashmaps branch 3 times, most recently from 3f9c428 to 1ffe566 Compare December 30, 2024 10:23
@Lysxia Lysxia force-pushed the contracts-hashmaps branch from 1ffe566 to ac914f0 Compare December 30, 2024 10:32
@Lysxia Lysxia merged commit 2ede1f0 into master Jan 3, 2025
6 checks passed
@Lysxia Lysxia deleted the contracts-hashmaps branch January 3, 2025 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants