Install creusot-rustc in a toolchain-dependent location #1314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: creusot-rustc is dynamically linked with rustc_driver, so it can't be run directly from the command line because it can't find its dependencies alone. Solution: Putting it in a special directory controlled by Creusot: 1. removes it from $PATH, suppressing the temptation to run it from the command line 2. allows cargo-creusot to detect incomplete upgrades (this prevents an obscure dynlink error if one updates the toolchain that creusot depends on and only reinstalls one of cargo-creusot or creusot-rustc). The installation of creusot-rustc is now handled by `cargo creusot setup install`.
Lysxia
force-pushed
the
install-creusot-rustc
branch
from
e290461 to
5982b9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671.
Problem: creusot-rustc is dynamically linked with rustc_driver, so it can't be run
directly from the command line because it can't find its dependencies alone.
Solution: Putting it in a special directory controlled by Creusot:
an obscure dynlink error if one updates the toolchain that creusot depends
on and only reinstalls one of cargo-creusot or creusot-rustc).
The installation of creusot-rustc is now handled by
cargo creusot setup install.