Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Why3's version to a specific hash & refactor CI #973

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Armael
Copy link
Contributor

@Armael Armael commented Mar 20, 2024

This PR does a number of related things to improve the setup workflow for users:

  • introduce a creusot-deps.opam file, to allow creating the required opam switch with one command
  • in the opam file, pin why3 to a specific "known good" commit, so that users don't pull an unknown version on why3 at setup
  • refactor the CI workflows to:
    • use the opam file with the "known good" commit on master/PRs
    • have an extra nightly workflow to test creusot against why3 master

The idea is then that upgrading the "known good" why3 commit is a manual operation (just editing the opam file), that I documented in HACKING.md.

@jhjourdan
Copy link
Collaborator

jhjourdan commented Mar 20, 2024

Very nice, I'd like to merge ASAP, if @xldenis agrees.

@xldenis
Copy link
Collaborator

xldenis commented Mar 20, 2024

Yep, this looks good to me.

@jhjourdan jhjourdan merged commit 9e1bd5c into creusot-rs:master Mar 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants