-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support some pep517 build backends #64
support some pep517 build backends #64
Conversation
I think this change shouldn't be necessary. If you use the |
This change looks good. Would you be able to create a new PR that only includes this fix, without any changes to formatting or import order? Also, please make sure to use the |
Do you have an example of when this bug is triggered? Maybe we should create a test in the command test suite that reproduces it. |
This changeset looks interesting, though I'm not familiar with PEP517. I'll need some time to review the changes since they're larger than the other fixes. Thanks again for your contributions! |
@cript0nauta thanks for the quick feedback! i broke out the pep517 changes into this pull request for your review #65 here's a pull request implementing the new cli option #66 here's a pull request showing how to replicate the recursion bug i encountered emmettbutler#4 thanks again! i'll look forward to your feedback. |
hatchling
andflit_core
PEP517 build backends--py
argument to the CLI allowing the user to specify the Python version to be used in the built shell