v1.0.46

Do not enforce unsafe optional chaining
crisp-oss · Aug 12, 2023 · ac20bff · ac20bff
1 parent 95edd6c
commit ac20bff
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-crisp",
-  "version": "1.0.45",
+  "version": "1.0.46",
   "description": "Custom EsLint Rules for Crisp",
   "main": "index.js",
   "author": "Crisp IM SAS",

diff --git a/rules/enforce-optional.js b/rules/enforce-optional.js
@@ -12,7 +12,9 @@ module.exports = {
   create(context) {
     const sourceCode = context.getSourceCode();
     // Search for `foo && foo.` or `foo && foo[`
-    const pattern = /\b(\w\S+)\s&&\s+\1\b[\[\.]/g;
+    // Notice: do not match `foo && foo.bar !==` or `foo && foo[bar] !==`, \
+    //   as the optional version would be unsafe
+    const pattern = /\b(\w\S+)\s&&\s+\1\b[\[\.](?!\w\S+\s\!\=\=)/g;
 
     return {
       Program() {