fix: unandled error while parsing URL (#160)

* fix: unandled error while parsing URL * adds test
cristianoliveira · Jun 12, 2024 · ff38392 · ff38392
1 parent dba47a7
commit ff38392
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/.version b/.version
@@ -1 +1 @@
-v0.3.2
+v0.4.1
diff --git a/proxy/service.go b/proxy/service.go
@@ -24,8 +24,12 @@ func NewService(name string, rawURL string) (Service, error) {
 	}
 
 	url, err := url.ParseRequestURI(rawURL)
+	if err != nil {
+		return Service{}, fmt.Errorf("Error parsing URL '%v': %v", rawURL, err)
+	}
+
 	isInvalidHostname := len(url.Hostname()) == 0 || strings.Contains(url.Hostname(), ":")
-	if err != nil || isInvalidHostname {
+	if isInvalidHostname {
 		return Service{}, fmt.Errorf("URL '%v' is invalid, example of valid URL 'http://example.com:8080'", rawURL)
 	}
 

diff --git a/proxy/service_test.go b/proxy/service_test.go
@@ -54,6 +54,12 @@ func TestNewService(t *testing.T) {
 			serviceURL:  "http://localhost:8080",
 			expectError: true,
 		},
+		{
+			title:       "a service containing an invalid URL is invalid",
+			serviceName: "ergoproxy",
+			serviceURL:  "http:///localhost:3000\n",
+			expectError: true,
+		},
 	}
 
 	for _, tc := range testCases {