First blockdevice implementation #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Create a device label
* Create a partition on a given blockdevice
Create a library to retrieve parted output.
Create a data structure instead of parsing strings everywhere. Implement unit tests.
- Add blockdevice-test cookbook - Add chefspec for volume_group
- fixed some errors in volume_partition resource - added tests for partitions TODO: - fix broken tests - add tests for delete action - start kitchen tests
Also: remove Windows from Kitchen EC2 tests
It will probably not work as is, as (at least) the offset and size properties need to be tweaked, and more tests added.
fs_type can be nil, and we don't look for it in load_current_value. Also: do not test msdos block device, pending later removal of msdos partition handling. Also: fix Rubocop.
- All sizes and offsets should now be on a boundary of 1MiB - updated rspec and kitchen tests to match new constraint - fixed install action for parted
* Remove partition name_or_type check, assume partition_type primary when partition_name is empty * Converge_if_changed for flags
Windows requires a correct partition type to install, so we must support them. This adds preliminary support for them. TODO: - Fix the tests for the partition type - Migrate to inspec tests
Handle properly the partition code on the volume_msdos_partition. Add inspec tests Fix rspec tests TODO: - use sgdisk for volume_gpt_partition implementation - handle partition code in volume_gpt_partition
Change-Id: Ie45eaf371033d7012dbb826d67d68af343ab11e7
olive42
approved these changes
Jun 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.