Pass the user specified token to consul maintenance primitive #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-clerc
previously approved these changes
Jun 4, 2024
Change-Id: Ibe2c225ebf04fd434ba75cbe1db416e0dc520f1b
Otherwise we use the "globally configured" token, that may change at any point in the chef run (because of diplomat model). Let's specify the token when requested. i.e. all checks calls. If an incorrect token is used, it may lacks permission to detect the node/service maintenance. Change-Id: I00b6a512e487151931d9b811eaead162b4ddde57
Annih
force-pushed
the
fix_consul_maintenance_primitive_token
branch
from
7237ee7 to
5214f49
Compare
jeremy-clerc
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise we use the "globally configured" token, that may change at any point in the chef run (because of diplomat model). Let's specify the token when requested. i.e. all checks calls.
If an incorrect token is used, it may lacks permission to detect the node/service maintenance.