Fix CI: update ruby version + Add retry on consul lock if failures #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mougams
commented
Oct 17, 2024
•
mougams
commented
- CI is failing due to lib compatibility versions
- Update code to ruby 3
- Add retry on consul lock if failures
mougams
force-pushed
the
update_ruby_version
branch
7 times, most recently
from
b462876 to
591ef5a
Compare
mougams
force-pushed
the
update_ruby_version
branch
from
591ef5a to
333c5fe
Compare
mougams
changed the title
Marking as breaking since this requires at minium ruby 3.0. Also updated minimal chef version is metadata file. - CI is failing due to lib compatibility versions - Update code to ruby 3.0.3 - Disable rubocop Style/HashSyntax - Update rubocop config namespace - Replace foodcritic by cookstyle in the CI run - Update kitchen docker: - update OS to latest
Since consul lock is based on consul infrastructure, we can hit issues when consul is restarting while locking choregraphie on consul. Indeed, we had cases where consul on leader node took times to restart causing Diplomat call failure.
mougams
force-pushed
the
update_ruby_version
branch
from
6f5e1e9 to
c4555df
Compare
jeremy-clerc
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.