Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better handling of the AD auth part #45

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Better handling of the AD auth part #45

wants to merge 3 commits into from

Conversation

nicolasgrieco
Copy link
Contributor

  • admin group for human users
  • admin group for API users
  • user group for read-only users
  • require_groupmembership to true by default

nicolasgrieco and others added 2 commits May 21, 2018 17:19
@nicolasgrieco
Better handling of the AD auth part
45726b9 
 - admin group for human users
 - admin group for API users
 - user group for read-only users
 - require_groupmembership to true by default
@nicolasgrieco
Merge branch 'master' into ad_auth_changes
fac280e
jmauro
jmauro suggested changes Jun 7, 2018
View reviewed changes
Copy link
Contributor

@jmauro jmauro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please clean up the commit, two commits but one changes.

@jmauro
Copy link
Contributor

jmauro commented Dec 12, 2018

Hello,
I still don't understand why you have 3 commits, could squash them?

Regards,
JM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmauro jmauro jmauro requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolasgrieco @jmauro