Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configure_timeout attribute for the wsus_server_subscription :configure action #15

Merged
merged 2 commits into from
Jan 26, 2016

Conversation

martinheg
Copy link
Contributor

Somewhat crude solution for #13 to allow for the timeout for the :configure action of the wsus_server_subscription provider to be set through an attribute.
I was seeing the same problem identified in the issue whereby the category synchronisation was not completing within the 300 seconds hardcoded by the powershell_out64 method.
This solution sets the default timeout for powershellout_64 as 300 seconds, but allows for that to be overridden.
In the case of wsus_server_subscription I pull that timeout from an attribute (which itself is defaulted to 900 seconds).

@Annih
Copy link
Contributor

Annih commented Jan 25, 2016

Hello @martinheg thanks for your nice contribution :)
Indeed, this seems to fix #13, I'll just perform some tests today before merging.

@kamaradclimber
Copy link

lgtm

@Annih
Copy link
Contributor

Annih commented Jan 26, 2016

Ok for me, but keep in mind that the powershell implementation might be removed when #12 will be implemented.

Thanks again @martinheg !

Annih added a commit that referenced this pull request Jan 26, 2016
Add configure_timeout attribute for the wsus_server_subscription :configure action
@Annih Annih merged commit a660747 into criteo-cookbooks:master Jan 26, 2016
@martinheg
Copy link
Contributor Author

Yep, 👍 . Thanks @Annih

@martinheg martinheg deleted the catsync_timeout_attribute branch January 29, 2016 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants