Refresh cookbook #38
Open
Refresh cookbook #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Annih
commented
Jul 30, 2024
Annih
commented
- use Github Actions instead of travis-ci
- Bump deps in Gemfile
- Refresh specs using latest chefspec, replace Berkshelf by Policyfile
- Apply cookstyle
- Remove obsolete dependency on windows cookbook
The only reason we use to have a dependency on Windows cookbook was the locate_sysnative_cmd helper. However this helper is not a "which" or "where", it just check whether the given path exist under the "native" system path. In our case, powershell.exe is not located there, but deeper in the directory structure, so "powershell.exe" was returned. So we don't need this helper and the Windows cookbook :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.