thumbnail: add support for other options #135
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a capability to add additional options to the thumbnail methods. I've done this by creating a separate options object, in a new package, so this is a bit of an opinionated suggestion for how to tackle the various additional options on other vips functions.
It isn't finished, as I'm not sure how to build the function arguments dynamically (so we can omit those that aren't specified). I need to achieve that to implement support for import and export profiles, and I'd like to apply that to scale and crop etc so if they're not specified in the options, they're not specified to vips, letting vips apply the defaults itself.
I will also add documentation, if you generally like / agree with this approach!