Send a subset of Spark properties on application start and end #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroville-criteo
force-pushed
the
send_spark_application_state_events
branch
from
7007242 to
e23d1ba
Compare
Willymontaz
requested changes
Sep 20, 2024
...rks/spark/src/main/java/com/criteo/hadoop/garmadon/spark/listener/GarmadonSparkListener.java
Show resolved
Hide resolved
| @@ -77,6 +78,43 @@ private void sendExecutorStateEvent(long time, State state, String executorId, S | |||
| this.eventHandler.accept(time, buildOverrideHeader(executorId), executorStateEvent.build()); | |||
| } | |||
|
|
|||
| private void sendApplicationStateEvent(long time, State state) { | |||
There was a problem hiding this comment.
I would give a try using the constants in core/src/main/scala/org/apache/spark/internal/config/package.scala to access the conf values because they can provide the default values as well
There was a problem hiding this comment.
Those constants are private, I cannot reference them from the listener
Log basic driver and executor properties. Sending an event when the application starts and when it ends will allow to catch configs that may have changed during execution, and differ from those sent in the spark-submit.
aroville-criteo
force-pushed
the
send_spark_application_state_events
branch
from
e23d1ba to
ffec359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log basic driver and executor properties.
Sending an event when the application starts and when it ends will allow to catch configs that may have changed during execution, and differ from those sent in the spark-submit.