Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add privacy manifest to the xcframework bundle #333

Merged
merged 1 commit into from
May 3, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,10 @@
# Criteo Publisher SDK Changelog
--------------------------------------------------------------------------------
## Version [6.1.1]

### Features
- Added Privacy manifest to xcframework bundle

--------------------------------------------------------------------------------
## Version [6.1.0]

2 changes: 1 addition & 1 deletion CriteoAdViewer/Sources/Info.plist
Original file line number Diff line number Diff line change
@@ -17,7 +17,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>6.1.0</string>
<string>6.1.1</string>
<key>CFBundleURLTypes</key>
<array>
<dict>
2 changes: 1 addition & 1 deletion CriteoAdViewer/UITests/Info.plist
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>BNDL</string>
<key>CFBundleShortVersionString</key>
<string>6.1.0</string>
<string>6.1.1</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>6.1.0</string>
<string>6.1.1</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>BNDL</string>
<key>CFBundleShortVersionString</key>
<string>6.1.0</string>
<string>6.1.1</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
2 changes: 1 addition & 1 deletion CriteoPublisherSdk.podspec
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Pod::Spec.new do |spec|
spec.name = "CriteoPublisherSdk"
spec.version = "6.1.0"
spec.version = "6.1.1"
spec.summary = "Criteo Publisher SDK for iOS"

spec.description = <<-DESC
22 changes: 12 additions & 10 deletions CriteoPublisherSdk/CriteoPublisherSdk.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
@@ -290,18 +290,18 @@
A84FF8932AB8892500DD3AE2 /* MRAIDOrientationPropertiesTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A84FF8922AB8892500DD3AE2 /* MRAIDOrientationPropertiesTests.swift */; };
A879179329A7230F00A3B798 /* CRMRAIDHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = A879179229A7230F00A3B798 /* CRMRAIDHandler.swift */; };
A879179629A771CF00A3B798 /* SwiftExtensions.swift in Sources */ = {isa = PBXBuildFile; fileRef = A879179529A771CF00A3B798 /* SwiftExtensions.swift */; };
A8ABDE462ACC31DA00E82CDE /* CR_SKAdNetworkHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = A8ABDE442ACC31DA00E82CDE /* CR_SKAdNetworkHandler.h */; };
A8ABDE472ACC31DA00E82CDE /* CR_SKAdNetworkHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = A8ABDE452ACC31DA00E82CDE /* CR_SKAdNetworkHandler.m */; };
A8ABDE552AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.h in Headers */ = {isa = PBXBuildFile; fileRef = A8ABDE532AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.h */; };
A8ABDE562AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.m in Sources */ = {isa = PBXBuildFile; fileRef = A8ABDE542AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.m */; };
A8ABDE582AD7E36E00E82CDE /* CR_SKAdNetworkImpressionTests.m in Sources */ = {isa = PBXBuildFile; fileRef = A8ABDE572AD7E36E00E82CDE /* CR_SKAdNetworkImpressionTests.m */; };
A8C3DF392A8E062100B6A4BE /* MRAIDResizeMessage.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8C3DF382A8E062100B6A4BE /* MRAIDResizeMessage.swift */; };
A8C3DF3D2A8E071700B6A4BE /* MRAIDCustomClosePosition.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8C3DF3C2A8E071700B6A4BE /* MRAIDCustomClosePosition.swift */; };
A8C3DF3F2A935D1C00B6A4BE /* MRAIDResizeHandler.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8C3DF3E2A935D1C00B6A4BE /* MRAIDResizeHandler.swift */; };
A8C3DF412A94EE3F00B6A4BE /* MRAIDResizeContainerView.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8C3DF402A94EE3F00B6A4BE /* MRAIDResizeContainerView.swift */; };
A8C3DF432A94FE4800B6A4BE /* CRPlacementType.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8C3DF422A94FE4800B6A4BE /* CRPlacementType.swift */; };
A8C3DF452A94FE6800B6A4BE /* CRMRAIDHandlerDelegate.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8C3DF442A94FE6800B6A4BE /* CRMRAIDHandlerDelegate.swift */; };
A8C3DF4F2A9E256200B6A4BE /* MRAIDResizeTests.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8C3DF4E2A9E256200B6A4BE /* MRAIDResizeTests.swift */; };
A8ABDE462ACC31DA00E82CDE /* CR_SKAdNetworkHandler.h in Headers */ = {isa = PBXBuildFile; fileRef = A8ABDE442ACC31DA00E82CDE /* CR_SKAdNetworkHandler.h */; };
A8ABDE472ACC31DA00E82CDE /* CR_SKAdNetworkHandler.m in Sources */ = {isa = PBXBuildFile; fileRef = A8ABDE452ACC31DA00E82CDE /* CR_SKAdNetworkHandler.m */; };
A8ABDE552AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.h in Headers */ = {isa = PBXBuildFile; fileRef = A8ABDE532AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.h */; };
A8ABDE562AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.m in Sources */ = {isa = PBXBuildFile; fileRef = A8ABDE542AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.m */; };
A8ABDE582AD7E36E00E82CDE /* CR_SKAdNetworkImpressionTests.m in Sources */ = {isa = PBXBuildFile; fileRef = A8ABDE572AD7E36E00E82CDE /* CR_SKAdNetworkImpressionTests.m */; };
A8E22E1B29DD75DF0094FFA4 /* MRAIDExpandMessage.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8E22E1A29DD75DF0094FFA4 /* MRAIDExpandMessage.swift */; };
A8E22E1D29DEFD4A0094FFA4 /* MRAIDState.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8E22E1C29DEFD4A0094FFA4 /* MRAIDState.swift */; };
A8E22E1F29DF06250094FFA4 /* CRFulllScreenContainer.swift in Sources */ = {isa = PBXBuildFile; fileRef = A8E22E1E29DF06250094FFA4 /* CRFulllScreenContainer.swift */; };
@@ -364,6 +364,7 @@
C07ABF0597CEB2DD36AE7B51 /* CR_FeedbackControllerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = C07ABBA46FCA43B62B82A2A0 /* CR_FeedbackControllerTests.m */; };
C07ABF991A19EF937114D960 /* CR_RemoteLogHandlerTests.m in Sources */ = {isa = PBXBuildFile; fileRef = C07AB53E83BAA3D26C8661A8 /* CR_RemoteLogHandlerTests.m */; };
CFA4C0E324487ED4003FC46B /* CR_FeedbackController.h in Headers */ = {isa = PBXBuildFile; fileRef = C07AB510AF4AF6C47D87E0F3 /* CR_FeedbackController.h */; };
DBB69F792BE404D00040DC89 /* PrivacyInfo.xcprivacy in Resources */ = {isa = PBXBuildFile; fileRef = A863B2D02B345281006E6476 /* PrivacyInfo.xcprivacy */; };
DF367C8A232974210044807B /* CRNativeAdUnit.h in Headers */ = {isa = PBXBuildFile; fileRef = DF367C84232971810044807B /* CRNativeAdUnit.h */; settings = {ATTRIBUTES = (Public, ); }; };
DF367C8B2329743C0044807B /* CRNativeAdUnit.m in Sources */ = {isa = PBXBuildFile; fileRef = DF367C85232971810044807B /* CRNativeAdUnit.m */; };
DF367C9B232AE8510044807B /* CR_NativeImage.m in Sources */ = {isa = PBXBuildFile; fileRef = DF367C97232AE8510044807B /* CR_NativeImage.m */; };
@@ -758,18 +759,18 @@
A863B2D02B345281006E6476 /* PrivacyInfo.xcprivacy */ = {isa = PBXFileReference; lastKnownFileType = text.xml; path = PrivacyInfo.xcprivacy; sourceTree = "<group>"; };
A879179229A7230F00A3B798 /* CRMRAIDHandler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CRMRAIDHandler.swift; sourceTree = "<group>"; };
A879179529A771CF00A3B798 /* SwiftExtensions.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SwiftExtensions.swift; sourceTree = "<group>"; };
A8ABDE442ACC31DA00E82CDE /* CR_SKAdNetworkHandler.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CR_SKAdNetworkHandler.h; sourceTree = "<group>"; };
A8ABDE452ACC31DA00E82CDE /* CR_SKAdNetworkHandler.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CR_SKAdNetworkHandler.m; sourceTree = "<group>"; };
A8ABDE532AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CR_SKAdNetworkFidelityParameter.h; sourceTree = "<group>"; };
A8ABDE542AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CR_SKAdNetworkFidelityParameter.m; sourceTree = "<group>"; };
A8ABDE572AD7E36E00E82CDE /* CR_SKAdNetworkImpressionTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CR_SKAdNetworkImpressionTests.m; sourceTree = "<group>"; };
A8C3DF382A8E062100B6A4BE /* MRAIDResizeMessage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MRAIDResizeMessage.swift; sourceTree = "<group>"; };
A8C3DF3C2A8E071700B6A4BE /* MRAIDCustomClosePosition.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MRAIDCustomClosePosition.swift; sourceTree = "<group>"; };
A8C3DF3E2A935D1C00B6A4BE /* MRAIDResizeHandler.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MRAIDResizeHandler.swift; sourceTree = "<group>"; };
A8C3DF402A94EE3F00B6A4BE /* MRAIDResizeContainerView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MRAIDResizeContainerView.swift; sourceTree = "<group>"; };
A8C3DF422A94FE4800B6A4BE /* CRPlacementType.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CRPlacementType.swift; sourceTree = "<group>"; };
A8C3DF442A94FE6800B6A4BE /* CRMRAIDHandlerDelegate.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CRMRAIDHandlerDelegate.swift; sourceTree = "<group>"; };
A8C3DF4E2A9E256200B6A4BE /* MRAIDResizeTests.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MRAIDResizeTests.swift; sourceTree = "<group>"; };
A8ABDE442ACC31DA00E82CDE /* CR_SKAdNetworkHandler.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CR_SKAdNetworkHandler.h; sourceTree = "<group>"; };
A8ABDE452ACC31DA00E82CDE /* CR_SKAdNetworkHandler.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CR_SKAdNetworkHandler.m; sourceTree = "<group>"; };
A8ABDE532AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = CR_SKAdNetworkFidelityParameter.h; sourceTree = "<group>"; };
A8ABDE542AD5460500E82CDE /* CR_SKAdNetworkFidelityParameter.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CR_SKAdNetworkFidelityParameter.m; sourceTree = "<group>"; };
A8ABDE572AD7E36E00E82CDE /* CR_SKAdNetworkImpressionTests.m */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.objc; path = CR_SKAdNetworkImpressionTests.m; sourceTree = "<group>"; };
A8E22E1A29DD75DF0094FFA4 /* MRAIDExpandMessage.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MRAIDExpandMessage.swift; sourceTree = "<group>"; };
A8E22E1C29DEFD4A0094FFA4 /* MRAIDState.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = MRAIDState.swift; sourceTree = "<group>"; };
A8E22E1E29DF06250094FFA4 /* CRFulllScreenContainer.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = CRFulllScreenContainer.swift; sourceTree = "<group>"; };
@@ -2077,6 +2078,7 @@
isa = PBXResourcesBuildPhase;
buildActionMask = 2147483647;
files = (
DBB69F792BE404D00040DC89 /* PrivacyInfo.xcprivacy in Resources */,
);
runOnlyForDeploymentPostprocessing = 0;
};
2 changes: 1 addition & 1 deletion CriteoPublisherSdk/Sources/Info.plist
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>FMWK</string>
<key>CFBundleShortVersionString</key>
<string>6.1.0</string>
<string>6.1.1</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
2 changes: 1 addition & 1 deletion CriteoPublisherSdk/Sources/Public/CRConstants.h
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@
#ifndef CRConstants_h
#define CRConstants_h

#define CRITEO_PUBLISHER_SDK_VERSION @"6.1.0"
#define CRITEO_PUBLISHER_SDK_VERSION @"6.1.1"

#define CRITEO_DEFAULT_REQUEST_TIMEOUT_IN_SECONDS 60
#define CRITEO_DEFAULT_BID_TTL_IN_SECONDS 15 * 60
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>BNDL</string>
<key>CFBundleShortVersionString</key>
<string>6.1.0</string>
<string>6.1.1</string>
<key>CFBundleVersion</key>
<string>1</string>
</dict>
2 changes: 1 addition & 1 deletion CriteoPublisherSdk/iTestHostApp/Info.plist
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@
<key>CFBundlePackageType</key>
<string>APPL</string>
<key>CFBundleShortVersionString</key>
<string>6.1.0</string>
<string>6.1.1</string>
<key>CFBundleVersion</key>
<string>1</string>
<key>LSRequiresIPhoneOS</key>

Unchanged files with check annotations Beta

let fetchLiveBidExpectation = expectation(description: "Fetch live bid finish expectation")
dependencyProvider.bidManager.fetchLiveBid(for: adUnit, withContext: contextData) {
[unowned self] bidReceived in

Check warning on line 458 in CriteoPublisherSdk/Tests/UnitTests/CR_BidManagerTests.swift

GitHub Actions / test

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
currentQueue?.async { [unowned self] in
let fetchLiveBidExpectation = expectation(description: "Fetch live bid finish expectation")
dependencyProvider.bidManager.fetchLiveBid(for: adUnit, withContext: contextData) {
[unowned self] bidReceived in

Check warning on line 507 in CriteoPublisherSdk/Tests/UnitTests/CR_BidManagerTests.swift

GitHub Actions / test

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
currentQueue?.async { [unowned self] in
let fetchLiveBidExpectation = expectation(description: "Fetch live bid finish expectation")
dependencyProvider.bidManager.fetchLiveBid(for: adUnit2, withContext: contextData) {
[unowned self] bidReceived in

Check warning on line 589 in CriteoPublisherSdk/Tests/UnitTests/CR_BidManagerTests.swift

GitHub Actions / test

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
currentQueue?.async { [unowned self] in
let fetchLiveBidExpectation = expectation(description: "Fetch live bid finish expectation")
dependencyProvider.bidManager.fetchLiveBid(for: adUnit, withContext: contextData) {
[unowned self] bidReceived in

Check warning on line 629 in CriteoPublisherSdk/Tests/UnitTests/CR_BidManagerTests.swift

GitHub Actions / test

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
currentQueue?.async { [unowned self] in
let fetchLiveBidExpectation = expectation(description: "Fetch live bid finish expectation")
dependencyProvider.bidManager.fetchLiveBid(for: adUnit, withContext: contextData) {
[unowned self] bidReceived in

Check warning on line 710 in CriteoPublisherSdk/Tests/UnitTests/CR_BidManagerTests.swift

GitHub Actions / test

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
currentQueue?.async { [unowned self] in
let fetchLiveBidExpectation = expectation(description: "Fetch live bid finish expectation")
dependencyProvider.bidManager.fetchLiveBid(for: adUnit, withContext: contextData) {
[unowned self] bidReceived in

Check warning on line 750 in CriteoPublisherSdk/Tests/UnitTests/CR_BidManagerTests.swift

GitHub Actions / test

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
currentQueue?.async { [unowned self] in
let fetchLiveBidExpectation = expectation(description: "Fetch live bid finish expectation")
dependencyProvider.bidManager.fetchLiveBid(for: adUnit, withContext: contextData) {
[unowned self] bidReceived in

Check warning on line 832 in CriteoPublisherSdk/Tests/UnitTests/CR_BidManagerTests.swift

GitHub Actions / test

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
currentQueue?.async { [unowned self] in
let fetchLiveBidExpectation = expectation(description: "Fetch live bid finish expectation")
dependencyProvider.bidManager.fetchLiveBid(for: adUnit, withContext: contextData) {
[unowned self] bidReceived in

Check warning on line 872 in CriteoPublisherSdk/Tests/UnitTests/CR_BidManagerTests.swift

GitHub Actions / test

Closure Parameter Position Violation: Closure parameters should be on the same line as opening brace (closure_parameter_position)
currentQueue?.async { [unowned self] in
[dfpViewChecker.bannerView loadRequest:bannerDfpRequest];
BOOL renderedProperly = [dfpViewChecker waitAdCreativeRendered];
XCTAssertTrue(renderedProperly);

Check failure on line 103 in CriteoPublisherSdk/Tests/IntegrationTests/CR_DfpNativeFunctionalTests.m

GitHub Actions / test

test_givenValidNative_whenLoadingNative_thenDfpViewContainsNativeCreative, ((renderedProperly) is true) failed

Check failure on line 103 in CriteoPublisherSdk/Tests/IntegrationTests/CR_DfpNativeFunctionalTests.m

GitHub Actions / test

test_givenValidNative_whenLoadingNative_thenDfpViewContainsNativeCreative, ((renderedProperly) is true) failed

Check failure on line 103 in CriteoPublisherSdk/Tests/IntegrationTests/CR_DfpNativeFunctionalTests.m

GitHub Actions / test

test_givenValidNative_whenLoadingNative_thenDfpViewContainsNativeCreative, ((renderedProperly) is true) failed

Check failure on line 103 in CriteoPublisherSdk/Tests/IntegrationTests/CR_DfpNativeFunctionalTests.m

GitHub Actions / test

test_givenValidNative_whenLoadingNative_thenDfpViewContainsNativeCreative, ((renderedProperly) is true) failed

Check failure on line 103 in CriteoPublisherSdk/Tests/IntegrationTests/CR_DfpNativeFunctionalTests.m

GitHub Actions / test

test_givenValidNative_whenLoadingNative_thenDfpViewContainsNativeCreative, ((renderedProperly) is true) failed

Check failure on line 103 in CriteoPublisherSdk/Tests/IntegrationTests/CR_DfpNativeFunctionalTests.m

GitHub Actions / test

test_givenValidNative_whenLoadingNative_thenDfpViewContainsNativeCreative, ((renderedProperly) is true) failed
}
#pragma mark - Private methods