Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CRL examples #120

Merged
merged 6 commits into from
Nov 28, 2021
Merged

Add CRL examples #120

merged 6 commits into from
Nov 28, 2021

Conversation

shoracek
Copy link
Contributor

This pull request modifies the structure for CRL checking and adds several CRL examples.

@mukrop
Copy link
Member

mukrop commented Nov 23, 2021

@zacikpa fixed this in #121. Try rebasing on master, hopefully the CI will pass then.

zacikpa
zacikpa reviewed Nov 24, 2021
View reviewed changes
Copy link
Contributor

@zacikpa zacikpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it locally with the web running and everything looks fine to me. Having 11 new errors covered is very nice.

I listed some small nitpicks, but nothing serious. What do you think, @mukrop?

_data/errors/openssl.yml Show resolved Hide resolved
validation/Makefile Show resolved Hide resolved
validation/certs/utils/io.py Show resolved Hide resolved
validation/clients/openssl/client.c Show resolved Hide resolved
mukrop
mukrop approved these changes Nov 28, 2021
View reviewed changes
Copy link
Member

@mukrop mukrop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks. The second CI won't run as you're doing a PR from your fork. I've tested everything locally, that's sufficient.

@mukrop mukrop merged commit ad487a1 into crocs-muni:master Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacikpa zacikpa zacikpa approved these changes

@mukrop mukrop mukrop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shoracek @mukrop @zacikpa