Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch generator #77

Closed
wants to merge 27 commits into from
Closed

Conversation

a4z
Copy link
Contributor

@a4z a4z commented Nov 24, 2023

Start with :
Add script to get a generator from a pull request in the djinni-generator repo

More to come, The conan download needs to be replaced,
and I think getting the generator via cmake download a (pre) release is a good idea

We might commit this script to enable that feature for #76 sooner.
Needs some adoption in the CI

@a4z a4z closed this Dec 22, 2023
@a4z a4z reopened this Dec 22, 2023
@a4z a4z closed this Dec 22, 2023
@a4z a4z reopened this Dec 22, 2023
@a4z
Copy link
Contributor Author

a4z commented Dec 22, 2023

Ok, this is stupid. Technically, it's possible to fetch the generator build of a PR from the generator repo.
Because GitHub requires authentication for doing this, we need to use secrets to pass an access token.
But, for PRs from a fork, access to secure tokens is not possible due to security reasons 😭

So the simple download of a PR pull request artifact, and thus for a wanted generator other than the latest release or the latest pre-release, is currently not possible.

@a4z a4z closed this Dec 23, 2023
@a4z a4z reopened this Dec 23, 2023
@a4z a4z closed this Dec 23, 2023
@a4z a4z reopened this Dec 23, 2023
@a4z a4z closed this Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant