Enhancement: Add support in JWT token refresh with shouldLoopInfinitely and nextReconcile fields #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arielsepton <[email protected]>
arielsepton
force-pushed
the
feature/duration-based-reconcile
branch
14 times, most recently
from
aba6285
to
f43b2ad
Compare
Signed-off-by: arielsepton <[email protected]>
arielsepton
force-pushed
the
feature/duration-based-reconcile
branch
from
f43b2ad
to
18aacf7
Compare
Signed-off-by: Ariel Septon <[email protected]>
arielsepton
force-pushed
the
feature/duration-based-reconcile
branch
from
461a2b1
to
5155087
Compare
Signed-off-by: Ariel Septon <[email protected]>
arielsepton
force-pushed
the
feature/duration-based-reconcile
branch
from
317a19d
to
c43e786
Compare
Signed-off-by: Ariel Septon <[email protected]>
arielsepton
force-pushed
the
feature/duration-based-reconcile
branch
from
2eaf486
to
366ea4e
Compare
arielsepton
added a commit
that referenced
this pull request
Jun 21, 2024
…ly and nextReconcile fields (#26) feat: add support for custom reconcile intervals with shouldLoopInfinitely and nextReconcile fields - Added `shouldLoopInfinitely` and `nextReconcile` fields to `DisposableRequest` resource. - Updated the `WithCustomPollIntervalHook` function to handle the new fields. - Enhanced example `DisposableRequest` definition to demonstrate usage of new fields. - Updated tests to cover new functionality. - This change allows for efficient handling of reconciliation intervals and looping behavior. Signed-off-by: arielsepton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces enhancements to the
DisposableRequestresource, enabling token refresh via the newshouldLoopInfinitelyandnextReconcilefields. These additions allow for continuous reconciliation based on a specified interval, ensuring the timely renewal of JWT tokens.Changes:
nextReconcilefield inDisposableRequest.shouldLoopInfinitely, andnextReconcilefields to theDisposableRequestspec to control reconciliation behavior and retry logic.DisposableRequestdocumentation with examples and detailed explanations for the new fields.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested