feat: support labels and annotations for secrets #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the ability to define labels and annotations for secrets created or managed by requests. This enhancement allows users to specify metadata directly in the secretInjectionConfigs field, simplifying secret management and reducing external resource dependencies. Signed-off-by: Ariel Septon <[email protected]>
arielsepton
force-pushed
the
feat/add-secret-labels-annotations
branch
from
04fe7ac
to
5a61c62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances secret management functionality for the
DisposableRequestandRequestresources by extending theSecretInjectionConfigfield with the following updates:Metadata Support:
Metadatafield to enable users to define labels and annotations for Kubernetes secrets created and managed by theDisposableRequestandRequestresources.KeyMappings Support:
KeyMappingsfield to support injecting multiple key-value pairs into a single Kubernetes secret through a singleSecretInjectionConfig.Deprecations:
SecretKeyandResponsePathfields as deprecated. Users are encouraged to migrate to the more flexibleKeyMappingsfield.Why is this needed?
Enables users to attach labels and annotations to secrets, improving resource management.
Simplifies the management of multiple key-value pairs within a single secret, reducing configuration complexity.
Backward Compatibility
SecretKeyandResponsePathwill continue to function but are now considered deprecated.Testing
Extended test coverage to validate the behavior of the new
MetadataandKeyMappingsfields.Verified the updated functionality for both
DisposableRequestandRequestresources in a Kubernetes cluster.Related Issue
Resolves: #70