-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update to function-sdk-go:v0.3.0 #81
Conversation
Signed-off-by: Jared Watts <[email protected]>
Ah, looks like Renovate was trying to do something similar with #80, but since this requires some manual updates to the xfn v1 types, I'll go ahead and set this PR to close that one (and a few others). Thank you though Renovate! Looks like errors for building now though, I think because of the go version bump without also bumping the CI workflow files. I'll look into that too. |
Signed-off-by: Jared Watts <[email protected]>
Sweet, all checks (linting/building/etc.) are passing green now! 🟢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM...
Although we should make a follow up issue once this is fixed in Crossplane Core crossplane/crossplane#5971 to update the package metadata api version.
Docs update PR to update the go function guide as well: crossplane/docs#814 |
Good call @blakeromano, thanks for taking a look and thanks for that reminder! I've opened #82 to track that bump 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jbw976 and @blakeromano 🙏
Description of your changes
This PR bumps this template repo up to the latest release of function-sdk-go:v0.3.0.
Release notes: https://github.com/crossplane/function-sdk-go/releases/tag/v0.3.0
Closes #80
Closes #72
Closes #71
I've tested this locally with the steps from the main README.md, all of which succeeed:
I'll also take this for a test spin through the Write a Composition Function in Go guide in the docs.
I have: