Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: built in variable api #2899

Merged
merged 6 commits into from
Nov 28, 2024
Merged

feat: built in variable api #2899

merged 6 commits into from
Nov 28, 2024

Conversation

CKY-
Copy link
Collaborator

@CKY- CKY- commented Nov 20, 2024

Description of the Change

added an api endpoint for registered variables

Applicable Issues

#2898

Testing

http://localhost:7472/api/v1/variables returns an alphabetised array of all variables

Screenshots

@CKY- CKY- requested a review from ebiggz as a code owner November 20, 2024 22:55
Copy link
Member

@ebiggz ebiggz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Just a suggestion for simplification and then I think this looks good to go!

src/server/api/v1/controllers/variableApiController.js Outdated Show resolved Hide resolved
@CKY-
Copy link
Collaborator Author

CKY- commented Nov 28, 2024

thank you for the review and simplification

@CKY- CKY- requested a review from ebiggz November 28, 2024 05:40
@ebiggz ebiggz merged commit 1d516f5 into crowbartools:v5 Nov 28, 2024
1 check passed
@CKY- CKY- deleted the v5-variable-api branch January 1, 2025 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants