Improve CTI Taxonomy documentation #685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
buixor
approved these changes
Nov 27, 2024
AlteredCoder
changed the title
rr404
reviewed
Nov 28, 2024
| @@ -22,11 +22,21 @@ export const columns = [ | |||
|
|
|||
| <GithubIconRender url={fpURL}></GithubIconRender> | |||
|
|
|||
| IPs in this category are considered completely safe and trusted. Alerts triggered by these IPs are likely due to misconfiguration or overly sensitive alerting rules. | |||
There was a problem hiding this comment.
Can we tell a bit more about our process of qualifying an IP as SAFE ?
Say that we have a list of genuine know crawlers exposing their IPs and ranges and that we take those in account to qualify an IP as SAFE.
Safe also means that it has no malicious intent, not that it isn't triggering certain scenarios, mainly crawling scenarios
rr404
reviewed
Nov 28, 2024
|
|
||
| :::warning | ||
|
|
||
| You might want to investigate any alerts associated with these IPs to ensure your configuration is correct. |
There was a problem hiding this comment.
Do we have doubts about FP ?
Ideally we should NOt have doubt if we qualify them as FP with a strict list of genuine crawlers and safe bots
rr404
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.