-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Send error notification to slack #108
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ce1bc8e
send error notification to slack
jorganisak ca6ffab
Merge remote-tracking branch 'origin/master' into send-error-notifica…
jorganisak 7a95c33
use err func, not emitter
jorganisak fac4341
Merge remote-tracking branch 'origin/master' into send-error-notifica…
jorganisak ec5bcc2
lint fix
jorganisak 3835527
Merge remote-tracking branch 'origin/master' into send-error-notifica…
jorganisak 5673b91
async errFunc
jorganisak File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
const slackapi = require("~slack/webApi"); | ||
const { TECH_CHANNEL } = require("~slack/constants"); | ||
const { findChannelByName } = require("~slack/channels"); | ||
|
||
const sentErrors = []; | ||
|
||
module.exports = async function sendErrorNotification(error) { | ||
/** | ||
* | ||
*/ | ||
const now = new Date(); | ||
|
||
const twoHoursAgo = new Date(now.getTime() - 120 * 60000); | ||
|
||
let shouldSend = true; | ||
|
||
for (const sentError of sentErrors) { | ||
// dont send if error occured within last 2 hours | ||
if ( | ||
sentError[0] === error.message && | ||
sentError[1].getTime() > twoHoursAgo.getTime() | ||
) { | ||
shouldSend = false; | ||
} | ||
} | ||
|
||
if (shouldSend) { | ||
let errText = `${error.stack}`; | ||
errText = `<!here|here> - We've got an error!\n\`\`\`${errText}\`\`\``; | ||
|
||
const wgTechChannel = await findChannelByName(TECH_CHANNEL); | ||
await slackapi.chat.postMessage({ | ||
channel: wgTechChannel.id, | ||
text: errText, | ||
}); | ||
|
||
sentErrors.push([error.message, now]); | ||
} | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional nit: can you make the function async and await the sendError? functionally the same, but a bit more resistant to a potential weird future change-detector update