Delivery: Save volunteer phone number #174
Open
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ifearcompilererrors
changed the title
| @@ -221,7 +221,6 @@ describe("findDeliveryNeededRequests", () => { | |||
| }); | |||
|
|
|||
| describe("when an error occurs", () => { | |||
| let result; | |||
There was a problem hiding this comment.
@sandfort added you as a reviewer here since i believe you're helping out with airtable test suites
sandfort
approved these changes
Nov 10, 2020
piratefsh
reviewed
Nov 14, 2020
There was a problem hiding this comment.
Yay thanks for working on this!! Code looks good to me, I just have a couple of questions:
- I'm a bit worried that the placeholder phone number can be confusing. I'm not up to date with UI best practices though, any thoughts on whether its more helpful to have a placeholder vs blank?
- Just curious, did we have to disable country code to get autofill to work?
Thank you for taking a look!
I can see how this is confusing- let me see what I can adjust based on this https://medium.com/nextux/form-design-best-practices-9525c321d759
Yes, MuiPhoneNumber pre-populated the input value with the country code, and since we discard the country code prefix anyway i disabled it. The input value needs to be blank for autofill to kick in |
ifearcompilererrors
force-pushed
the
feature/delivery-autofill
branch
from
4c2b9d6 to
f3c061d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #156
How to test