Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with collection attributes not being recognized #221

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

agrancaric
Copy link
Collaborator

@agrancaric agrancaric commented Sep 20, 2024

Basic information

  • nrich version:
    2.6.0
  • Module:
    nrich-search

Additional information

Description

Summary

Fix issue with collection attributes not being recognized and using a join instead of exist query by default

Details

Fix issue with collection attributes not being recognized and using a join instead of exist query by default

Related issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I have read the project's CONTRIBUTING document
  • I have checked my code with the project's static analysis tooling
  • I have formatted my code with the project's IDEA code-style configuration
  • I have checked my code for misspellings
  • I have organized my changes in easy-to-follow commits
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests pass.

@agrancaric agrancaric requested a review from jzrilic September 20, 2024 08:18
@agrancaric agrancaric self-assigned this Sep 20, 2024
@agrancaric agrancaric force-pushed the bugfix_fixPluralAttributeRestriction branch from 9291b09 to 588bc34 Compare September 20, 2024 08:55
@jzrilic jzrilic changed the title Fix issue with collection attributes not being recognized and using a… Fix issue with collection attributes not being recognized Sep 20, 2024
@jzrilic jzrilic merged commit 05b576e into master Sep 20, 2024
6 checks passed
@jzrilic jzrilic deleted the bugfix_fixPluralAttributeRestriction branch September 20, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants