Adding ignoreSubpaths possibility #432
Conversation
valibali
commented
Feb 26, 2024
valibali
commented
- Getter for IgnoreSubpaths() added
- Cleaning of paths (removing leading and internal control ["../"] elements)
- checkFile() updated
valibali
force-pushed
the
feature/add-ignore-subpath-feature
branch
2 times, most recently
from
bffe25d to
33cbd82
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (99.4%)
Files: 21
Issues: 1
gofmt: 100%
go_vet: 100%
gocyclo: 100%
golint: 95%
pkg/features/getters.go
Line 169: warning: comment on exported function GetIgnoreSubpaths should be of the form "GetIgnoreSubpaths ..." (golint)
ineffassign: 100%
license: 100%
misspell: 100%
This report was generated using GoGitOps.
valibali
force-pushed
the
feature/add-ignore-subpath-feature
branch
from
33cbd82 to
503986a
Compare
| return err | ||
| } | ||
| for _, subpath := range ignoreSubpaths { | ||
| // Remove any leading "../" from the subpath |
There was a problem hiding this comment.
This is a surprising thing, why are we removing some part of the path that the user has supplied?
There was a problem hiding this comment.
I thought users would give a path with a potential leading "../", (which would never match), but later I figured it's unlikely.
I'll update the docs that the given paths should be relative to the application base directory.
| subpath = subpath[len("../"):] | ||
| } | ||
|
|
||
| if strings.Contains(path, filepath.Clean(subpath)) { |
There was a problem hiding this comment.
I'd like a solid match here. We're only matching directories, so I'd check for IsDir() and matching, and then return SkipDir instead.
If I have
/bar
/foo/bar
And I ignore /bar I'd like it only to ignore the first path, not the second.
There was a problem hiding this comment.
Gosh, that was lame. You're absolutely right. I'm doing the update.
There was a problem hiding this comment.
GoGitOps Review
Grade: A+ (100.0%)
Files: 21
Issues: 0
gofmt: 100%
go_vet: 100%
gocyclo: 100%
golint: 100%
ineffassign: 100%
license: 100%
misspell: 100%
This report was generated using GoGitOps.
|
Hey @valibali. Any update on this? Thanks |
|
Yo. |
