Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(oci): attempt to push using only registry/namespace #176

Merged
merged 1 commit into from
Jul 17, 2024
Merged

ci(oci): attempt to push using only registry/namespace #176

merged 1 commit into from
Jul 17, 2024

Conversation

andrewazores
Copy link
Member

See #175 #174 #173

@andrewazores andrewazores merged commit a58569b into cryostatio:main Jul 17, 2024
8 of 11 checks passed
@andrewazores andrewazores deleted the ci-oci-namespace branch July 17, 2024 19:43
@tthvo
Copy link
Member

tthvo commented Jul 17, 2024

We might clash with https://github.com/cryostatio/cryostat-legacy/pkgs/container/cryostat?

@andrewazores
Copy link
Member Author

andrewazores commented Jul 17, 2024 •
edited
Loading

Yea, that's what happens: https://github.com/cryostatio/cryostat-legacy/pkgs/container/cryostat/245109975?tag=2.0.0-dev

Need some way to get the chart releaser to package the chart with cryostat-helm as its name, not just cryostat.

@andrewazores
Copy link
Member Author

Or actually, I guess it's helm push which is giving us problems, not the chart releaser.

@tthvo
Copy link
Member

tthvo commented Jul 17, 2024

The chart releaser is also having issue I think since the release still got published. Can we just use helm package?

@andrewazores
Copy link
Member Author

Maybe we can just hack it by patching the charts/cryostat/Chart.yaml to set name: cryostat-helm within the CI run...

@tthvo
Copy link
Member

tthvo commented Jul 17, 2024

https://trstringer.com/helm-charts-github-container-registry/

@tthvo
Copy link
Member

tthvo commented Jul 17, 2024

Maybe we can just hack it by patching the charts/cryostat/Chart.yaml to set name: cryostat-helm within the CI run...

That sounds reasonable to me :D

@tthvo
Copy link
Member

tthvo commented Jul 17, 2024

Also, I figured out the skip_upload. Seems like it is only available on main, not latest 1.6.0 :D

@andrewazores andrewazores mentioned this pull request Jul 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ci safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewazores @tthvo