Bugfix: try getting txid directly if get_transactions fails #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After broadcasting a transaction that sends funds from a wallet to itself, it did not appear in the wallet's listtransactions rpc result, so calling fetch_transactions isn't good enough. I'm not sure if this is a bug in bitcoin-core v22.0.0 or if things changed in newer versions.
✅ Deploy Preview for specter-desktop-docs canceled.
|
|
Addressing this issue: #2475 |
|
@oren-z0 can you test with master again please? (just merged the above mentioned fix). |
|
@moneymanolis I tested again and it seems your latest commits fixed the problem 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After broadcasting a transaction that sends
funds from a wallet to itself, it did not appear
in the wallet's listtransactions rpc result, so calling fetch_transactions isn't good enough.
I'm not sure if this is a bug in bitcoin-core
v22.0.0 or if things changed in newer
versions.
closes #2475