Serial communication during setup(), checksum on serial messages

src/main.cpp

@@ -616,8 +616,9 @@ void setupCommunication()
 
 
   g_serial_comm = new SerialComm(s_protocol);
-
-  g_data_source->connect();
+  g_serial_comm->setupTickCallback([] { // temporary timed callback before we enter the main loop
+    g_serial_comm->loop();
+  });
 }
 
 void setupLogo()
@@ -796,6 +797,7 @@ void setup() {
   setupMenu();
 
   setupLogo();
+  setupCommunication();
 
   CCLOGI("<Firmware> %s",Utils::getDeviceInfo("\n<Firmware> ").c_str());
 
@@ -817,7 +819,9 @@ void setup() {
   g_display->replaceAction(g_price_action);
 
   setupNTP();
-  setupCommunication();
+
+  g_data_source->connect();
+  g_serial_comm->detachTicker();
 }
 
 void loop() {

src/protocol.cpp

@@ -46,7 +46,7 @@ static const char *g_local_commands[] = {
   "getDeviceInfo","addWiFiAP","removeWiFiAP","getWiFiAPs"
 };
 
-// local commands 
+// TODO: local commands 
 // getDeviceInfo (include screen IDs and info), 
 // eraseEEPROM, 
 // getdiagnostic info (wifi signal strenght etc.)
@@ -220,8 +220,8 @@ void CC_Protocol::setDefaultCallbacks()
   if (m_is_remote == false) {
     setCommandCallback("getDeviceInfo", [this](const JsonDocument& j) {
       sendHello();
-      sendDiagnostics();
-      sendAllParameters();
+//      sendDiagnostics();
+//      sendAllParameters();
     });
   }
 }

src/serial.cpp

@@ -20,13 +20,13 @@
 #include "serial.hpp"
 #include "log.hpp"
 
-static const char* LOGTAG = "Serial";
+//static const char* LOGTAG = "Serial";
 
 void SerialComm::loop()
 {
   String line = m_prot->readyToSend();
   if (line.length()>0)
-    Serial.printf_P(PSTR("|SERIALCOMM|%s\n"),line.c_str());
+    Serial.printf_P(PSTR("|SERIALCOMM|%s|%02X|\n"),line.c_str(), Utils::calculateChecksum(line.c_str()));
 
   while(Serial.available()>0) {
     int ch = Serial.read();
@@ -36,7 +36,7 @@ void SerialComm::loop()
       continue;
 
     if (ch == '\n') {
-      CCLOGD("data: '%s'", m_buffer.c_str());
+//      CCLOGD("data: '%s'", m_buffer.c_str());
       m_prot->dataReceived(m_buffer.c_str(), m_buffer.length());
       m_buffer = "";
     } else {
@@ -45,3 +45,12 @@ void SerialComm::loop()
   }
 }
 
+void SerialComm::setupTickCallback(Ticker::callback_t callback)
+{
+    m_ticker.attach(c_milis_per_tick / 1000.0,callback);
+}
+
+void SerialComm::detachTicker()
+{
+  m_ticker.detach();
+}

src/serial.hpp

@@ -31,8 +31,13 @@ class SerialComm
   SerialComm(CC_Protocol *prot): m_prot(prot), m_buffer("")
   {}
 
+  void setupTickCallback(Ticker::callback_t callback);
+  void detachTicker();
+
   void loop();
 private:
+  Ticker m_ticker; // for communicating via serial during setup()
   CC_Protocol *m_prot;
   String m_buffer;
+  const int c_milis_per_tick = 333;
 };

src/utils.cpp

@@ -199,4 +199,15 @@ String getDisconnectReason(WiFiDisconnectReason reason)
   return F("Unknown");
 }
 
+// simple xor checksum
+unsigned char calculateChecksum(const String& text)
+{
+  unsigned char c = 0;
+  const char*s = text.c_str();
+  while(*s) {
+    c ^= *s++;
+  }
+  return c;
+}
+
 }

src/utils.hpp

@@ -41,4 +41,5 @@ String uint64ToString(uint64_t input);
 float getMemoryFragmentation();
 String getDeviceInfo(const String& sep=" ");
 String getDisconnectReason(WiFiDisconnectReason reason);
+unsigned char calculateChecksum(const String& text);
 }