Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Health check: Get affected fs nodes of result #150

Closed
wants to merge 3 commits into from

Conversation

infeo
Copy link
Member

@infeo infeo commented Nov 20, 2022

This PR adds the method getCausingCiphertextNodes() to the interface DiagnosticResult.

The method is intended to list ciphertext resources, which triggered the concrete result.

@infeo infeo added this to the 2.5.0 milestone Nov 20, 2022
@infeo infeo requested a review from overheadhunter November 20, 2022 20:10
@infeo infeo self-assigned this Nov 20, 2022
@infeo infeo marked this pull request as draft November 21, 2022 11:50
@infeo
Copy link
Member Author

infeo commented Nov 21, 2022

This "Feature" needs more thought.

The intention was to give the consumer the chance to see conflicting results (i.e. their fix would affect the same fs nodes). But the results are too loosley coupled.

For example, for path /d/AB/CDEFG/mumbJumbo.c9r exist two results A and B. The fix for A is to modify the attributes, for B is to move the node. Then you can first fix A and then B with success, but not first B and then A. This PR would only give the consumer the info, that there might be a conflict, but still outputs both results.

@infeo infeo closed this Nov 21, 2022
@infeo infeo removed this from the 2.5.0 milestone Nov 22, 2022
@infeo
Copy link
Member Author

infeo commented Nov 22, 2022

I openend #151 to discuss any possible solutions for fix resolving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant