Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to new hax naming. #774

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Adapt to new hax naming. #774

merged 1 commit into from
Jan 30, 2025

Conversation

maximebuyse
Copy link
Contributor

This removes some hardcoded names in raw fstar strings. We use the $ feature of hax-lib to make this more robust. With this changes, the extracted code lax-checks with both hax main and cryspen/hax#1199.

In some places, we need to use a workaround documented in cryspen/hax#1276 (comment)

Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with two nits

libcrux-ml-kem/Cargo.toml Outdated Show resolved Hide resolved
@maximebuyse maximebuyse force-pushed the adapt-to-new-hax-naming branch from 3ce9b09 to 4602719 Compare January 29, 2025 16:33
Copy link
Member

@franziskuskiefer franziskuskiefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please never force push on a branch in a PR. That makes reviewing impossible.

@franziskuskiefer franziskuskiefer merged commit 184f22d into main Jan 30, 2025
62 checks passed
@franziskuskiefer franziskuskiefer deleted the adapt-to-new-hax-naming branch January 30, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants